perf_counter: Fix perf_output_copy() WARN to account for overflow
Commit-ID: 53020fe81eecd0b7be295868ce5850ef8f41074e Gitweb: http://git.kernel.org/tip/53020fe81eecd0b7be295868ce5850ef8f41074e Author: Peter Zijlstra <[email protected]> AuthorDate: Wed, 13 May 2009 21:26:19 +0200 Committer: Ingo Molnar <[email protected]> CommitDate: Fri, 15 May 2009 09:46:59 +0200
perf_counter: Fix perf_output_copy() WARN to account for overflow
The simple reservation test in perf_output_copy() failed to take unsigned int overflow into account, fix this.
[ Impact: fix false positive warning with more than 4GB of profiling data ]
Signed-off-by Peter Zijlstra <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Corey Ashford <[email protected]>
LKML-Reference: <new-submission>
Signed-off-by Ingo Molnar <[email protected]>
--- kernel/perf_counter.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
kernel/perf_counter.c +5 -1
@@ -1927,7 +1927,11 @@ static void perf_output_copy(struct perf_output_handle *handle, handle->offset = offset; -WARN_ON_ONCE (handle->offset > handle->head); +/* +* Check we didn't copy past our reservation window, taking the +* possible unsigned int wrap into account. +*/ +WARN_ON_ONCE (((int )(handle->head - handle->offset)) <0 ); }#define perf_output_put (handle, x) \