perf tools: Makefile: Clean up `python/perf.so' rule

tip:perf/core tip-bot for Michael Witten 1 participant 1 message Apr 21, 2011 perf events

Share & tools

tip-bot for Michael Witten

author

2011-04-21 09:22 UTC #0 lore raw

Commit-ID:  3643b133f2cb8023e8cedcbef43215a99d7df561
Gitweb:     http://git.kernel.org/tip/3643b133f2cb8023e8cedcbef43215a99d7df561
Author:     Michael Witten <[email protected]>
AuthorDate: Sat, 9 Apr 2011 01:12:56 +0000
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 19 Apr 2011 08:18:36 -0300

perf tools: Makefile: Clean up `python/perf.so' rule

There is no need for a subshell or an explicit `export'; as per the POSIX Shell Command Language specification:

http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_09_01
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_10_02

It is only necessary to include the environment variable assignment just before the command to be run.

Also, it is better to use single-quotes, because GNU make might expand `$(BASIC_CFLAGS)' into something that the shell could interpret within double-quotes.

Acked-by Raghavendra D Prabhu <[email protected]>

Link http://lkml.kernel.org/n/[email protected] open here

Signed-off-by Michael Witten <[email protected]>

Signed-off-by Arnaldo Carvalho de Melo <[email protected]>

---
 tools/perf/Makefile |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

tools/perf/Makefile +4 -6

index 207dee5..aaf4dd3 100644
@@ -165,12 +165,10 @@ grep-libs = $(filter -l%,$(1))
 strip-libs = $(filter-out -l%,$(1))
 
 $(OUTPUT)python/perf.so: $(PYRF_OBJS)
-	$(QUIET_GEN)( \
-		export CFLAGS="$(BASIC_CFLAGS)"; \
-		python util/setup.py --quiet  build_ext --build-lib='$(OUTPUT)python' \
-			--build-temp='$(OUTPUT)python/temp' \
-	)
-
+	$(QUIET_GEN)CFLAGS='$(BASIC_CFLAGS)' python util/setup.py \
+	  --quiet build_ext \
+	  --build-lib='$(OUTPUT)python' \
+	  --build-temp='$(OUTPUT)python/temp'
 #
 # No Perl scripts right now:
 #