Skip to contentSkip to conversation

perf_counter tools: Replace isprint() with issane()

tip:perfcounters/core tip-bot for Peter Zijlstra 1 participant 1 message Jun 17, 2009 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  5aa75a0fd4bc6402899e06fdb853cab024d65055
Gitweb:     http://git.kernel.org/tip/5aa75a0fd4bc6402899e06fdb853cab024d65055
Author:     Peter Zijlstra <[email protected]>
AuthorDate: Mon, 15 Jun 2009 20:11:41 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 17 Jun 2009 19:23:53 +0200

perf_counter tools: Replace isprint() with issane()

The Git utils came with a ctype replacement that doesn't provide isprint(). Add a replacement.

Solves a build bug on certain distros.

Cc Peter Zijlstra <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>

LKML-Reference: <new-submission>

---
 tools/perf/builtin-report.c |    2 +-
 tools/perf/util/util.h      |    1 +
 2 files changed, 2 insertions(+), 1 deletions(-)
tools/perf/builtin-report.c +1 -1
index cd74b2e..707f60c 100644
@@ -1266,7 +1266,7 @@ static void trace_event(event_t *event)
 			for (j = 0; j < 15-(i & 15); j++)
 				cdprintf("   ");
 			for (j = 0; j < (i & 15); j++) {
-				if (isprint(raw_event[i-15+j]))
+				if (issane(raw_event[i-15+j]))
 					cdprintf("%c", raw_event[i-15+j]);
 				else
 					cdprintf(".");
tools/perf/util/util.h +1 -0
index 76590a1..ce9b514 100644
@@ -343,6 +343,7 @@ extern unsigned char sane_ctype[256];
 #define isdigit(x) sane_istest(x,GIT_DIGIT)
 #define isalpha(x) sane_istest(x,GIT_ALPHA)
 #define isalnum(x) sane_istest(x,GIT_ALPHA | GIT_DIGIT)
+#define issane(x)  sane_istest(x,GIT_SPACE | GIT_DIGIT | GIT_ALPHA | GIT_GLOB_SPECIAL | GIT_REGEX_SPECIAL)
 #define is_glob_special(x) sane_istest(x,GIT_GLOB_SPECIAL)
 #define is_regex_special(x) sane_istest(x,GIT_GLOB_SPECIAL | GIT_REGEX_SPECIAL)
 #define tolower(x) sane_case((unsigned char)(x), 0x20)