Skip to contentSkip to conversation

perf record: Disable profiling before draining the buffer

tip:perfcounters/core tip-bot for Peter Zijlstra 1 participant 1 message Sep 17, 2009 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  5abfd8bf28feeb633afdea2309fb0927d17606be
Gitweb:     http://git.kernel.org/tip/5abfd8bf28feeb633afdea2309fb0927d17606be
Author:     Peter Zijlstra <[email protected]>
AuthorDate: Thu, 17 Sep 2009 19:59:05 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 17 Sep 2009 20:02:47 +0200

perf record: Disable profiling before draining the buffer

I noticed that perf-record continues profiling itself after the child terminated and we're draining the buffer.

This can cause a _lot_ of overhead with --all recording - we keep and keep recording, which produces new and new events.

LKML-Reference: <new-submission>

---
 tools/perf/builtin-record.c |   13 ++++++++++++-
 1 files changed, 12 insertions(+), 1 deletions(-)
tools/perf/builtin-record.c +12 -1
index 5f3127e..2459e5a 100644
@@ -524,6 +524,7 @@ static int __cmd_record(int argc, const char **argv)
 	pid_t pid = 0;
 	int flags;
 	int ret;
+	unsigned long waking = 0;
 
 	page_size = sysconf(_SC_PAGE_SIZE);
 	nr_cpus = sysconf(_SC_NPROCESSORS_ONLN);
@@ -634,10 +635,20 @@ static int __cmd_record(int argc, const char **argv)
 		if (hits == samples) {
 			if (done)
 				break;
-			ret = poll(event_array, nr_poll, 100);
+			ret = poll(event_array, nr_poll, -1);
+			waking++;
+		}
+
+		if (done) {
+			for (i = 0; i < nr_cpu; i++) {
+				for (counter = 0; counter < nr_counters; counter++)
+					ioctl(fd[i][counter], PERF_COUNTER_IOC_DISABLE);
+			}
 		}
 	}
 
+	fprintf(stderr, "[ perf record: Woken up %ld times to write data ]\n", waking);
+
 	/*
 	 * Approximate RIP event size: 24 bytes.
 	 */