Skip to contentSkip to conversation

perf test: Add missing verbose output explaining the reason for failure

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Apr 23, 2016 perf events

lore
Share & tools
lore

tip-bot for Arnaldo Carvalho de Melo

author merge bot
#0 lore raw
Commit-ID:  6566feafb4dba4eef30a9c0b25e6f49f996178b6
Gitweb:     http://git.kernel.org/tip/6566feafb4dba4eef30a9c0b25e6f49f996178b6
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Tue, 19 Apr 2016 12:22:25 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 19 Apr 2016 12:39:36 -0300

perf test: Add missing verbose output explaining the reason for failure

One of the branches leading to an error had no debug message emitted, fix it, the new lines are:

  # perf test -v kallsyms
<SNIP>
  0xffffffff81001000: diff name v: xen_hypercall_set_trap_table k: hypercall_page
  0xffffffff810691f0: diff name v: try_to_free_pud_page k: try_to_free_pmd_page
<SNIP>
  0xffffffff8150bb20: diff name v: wakeup_expire_count_show.part.5 k: wakeup_active_count_show.part.7
  0xffffffff816bc7f0: diff name v: phys_switch_id_show.part.11 k: phys_port_name_show.part.12
  0xffffffff817bbb90: diff name v: __do_softirq k: __softirqentry_text_start
<SNIP>

This in turn exercises another bug, still under investigation, because those aliases _are_ in kallsyms, with the same name...

Cc Adrian Hunter <[email protected]>
Cc David Ahern <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Wang Nan <[email protected]>
Fixes ab414dcda8fa ("perf test: Fixup aliases checking in the 'vmlinux matches kallsyms' test")
Link http://lkml.kernel.org/n/[email protected] open here
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/tests/vmlinux-kallsyms.c | 3 +++
 1 file changed, 3 insertions(+)
tools/perf/tests/vmlinux-kallsyms.c +3 -0
index c05f1bd..e63abab 100644
@@ -163,6 +163,9 @@ next_pair:
 
 					pr_debug("%#" PRIx64 ": diff name v: %s k: %s\n",
 						 mem_start, sym->name, pair->name);
+				} else {
+					pr_debug("%#" PRIx64 ": diff name v: %s k: %s\n",
+						 mem_start, sym->name, first_pair->name);
 				}
 			}
 		} else