Skip to contentSkip to conversation

perf trace: Clarify that -e is about syscalls, not perf events in general

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message May 6, 2015 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  d303e85a5c19eb8d913951d1aa81556fc20b20af
Gitweb:     http://git.kernel.org/tip/d303e85a5c19eb8d913951d1aa81556fc20b20af
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 23 Apr 2015 12:02:07 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 29 Apr 2015 10:38:04 -0300

perf trace: Clarify that -e is about syscalls, not perf events in general

This comes from the desire of having -e/--expr to have the same meaning as for 'strace', while other perf tools use it for --event, which 'trace' honours, i.e. all perf tools have --event in common, but trace uses -e for strace's --expr.

Clarify it in the --help output.

---
 tools/perf/Documentation/perf-trace.txt | 2 +-
 tools/perf/builtin-trace.c              | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
tools/perf/Documentation/perf-trace.txt +1 -1
index ba03fd5..1db9c8b 100644
@@ -35,7 +35,7 @@ OPTIONS
 
 -e::
 --expr::
-	List of events to show, currently only syscall names.
+	List of syscalls to show, currently only syscall names.
 	Prefixing with ! shows all syscalls but the ones specified.  You may
 	need to escape it.
 
tools/perf/builtin-trace.c +1 -2
index 23fb081..d1139b6 100644
@@ -2660,8 +2660,7 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused)
 	OPT_BOOLEAN(0, "comm", &trace.show_comm,
 		    "show the thread COMM next to its id"),
 	OPT_BOOLEAN(0, "tool_stats", &trace.show_tool_stats, "show tool stats"),
-	OPT_STRING('e', "expr", &ev_qualifier_str, "expr",
-		    "list of events to trace"),
+	OPT_STRING('e', "expr", &ev_qualifier_str, "expr", "list of syscalls to trace"),
 	OPT_STRING('o', "output", &output_name, "file", "output file name"),
 	OPT_STRING('i', "input", &input_name, "file", "Analyze events in file"),
 	OPT_STRING('p', "pid", &trace.opts.target.pid, "pid",