Skip to contentSkip to conversation

x86, mce: trivial clean up for mce_intel_64.c

tip:x86/mce3 Andi Kleen 2 participants 2 messages May 29, 2009 1 message not in the archive

lore
Share & tools
lore

Andi Kleen

author
#1 lore raw
In reply to a message not in the archive
Quoted 6 lines

x86, mce: trivial clean up for mce_intel_64.c

Fix for:

WARNING: space prohibited between function name and open parenthesis '('
+ for_each_online_cpu (cpu) {

Sorry but that's just a bogus change. That's a loop and we always put spaces between the loop keyword and its condition.

Just because checkpatch.pl is too dumb to understand that is no reason to make the code worse like that.

-Andi

#2 lore raw
Quoted 4 lines · Andi Kleen
Quoted 4 lines

x86, mce: trivial clean up for mce_intel_64.c

Fix for:

Quoted 9 lines
Quoted 2 lines

WARNING: space prohibited between function name and open parenthesis '('
+ for_each_online_cpu (cpu) {

Sorry but that's just a bogus change. That's a loop and we always put spaces between the loop keyword and its condition.

Just because checkpatch.pl is too dumb to understand that is no reason to make the code worse like that.

Look at EVERY OTHER for_each_online_cpu in the kernel.

-hpa