Skip to contentSkip to conversation

perf ui: Make END go to the last entry, not the top of the last page

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Jul 18, 2010 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  63f20e744a595444f7ab1d47a29c5b74830feb47
Gitweb:     http://git.kernel.org/tip/63f20e744a595444f7ab1d47a29c5b74830feb47
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 15 Jul 2010 07:21:07 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Sat, 17 Jul 2010 15:44:43 -0300

perf ui: Make END go to the last entry, not the top of the last page

Cc: Frederic Weisbecker <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Stephane Eranian <[email protected]>
LKML-Reference: <new-submission>

---
 tools/perf/util/newt.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
tools/perf/util/newt.c +4 -4
index 06f248f..932f124 100644
@@ -491,11 +491,11 @@ static int ui_browser__run(struct ui_browser *self, struct newtExitStruct *es)
 			break;
 		case NEWT_KEY_END:
 			offset = self->height - 1;
+			if (offset >= self->nr_entries)
+				offset = self->nr_entries - 1;
 
-			if (offset > self->nr_entries)
-				offset = self->nr_entries;
-
-			self->index = self->first_visible_entry_idx = self->nr_entries - 1 - offset;
+			self->index = self->nr_entries - 1;
+			self->first_visible_entry_idx = self->index - offset;
 			self->seek(self, -offset, SEEK_END);
 			break;
 		case NEWT_KEY_RIGHT: