Skip to contentSkip to conversation

perf_event: x86: Optimize x86_pmu_disable()

tip:perf/core tip-bot for Peter Zijlstra 1 participant 1 message Jan 29, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw
Commit-ID:  6c9687abeb24d5b7aae7db5be070c2139ad29e29
Gitweb:     http://git.kernel.org/tip/6c9687abeb24d5b7aae7db5be070c2139ad29e29
Author:     Peter Zijlstra <[email protected]>
AuthorDate: Mon, 25 Jan 2010 11:57:25 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 29 Jan 2010 09:01:43 +0100

perf_event: x86: Optimize x86_pmu_disable()

x86_pmu_disable() removes the event from the cpuc->event_list[], however since an event can only be on that list once, stop looking after we found it.

Cc Stephane Eranian <[email protected]>

LKML-Reference: <new-submission>

---
 arch/x86/kernel/cpu/perf_event.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/kernel/cpu/perf_event.c +1 -0
index 33c889f..66de282 100644
@@ -1884,6 +1884,7 @@ static void x86_pmu_disable(struct perf_event *event)
 				cpuc->event_list[i-1] = cpuc->event_list[i];
 
 			--cpuc->n_events;
+			break;
 		}
 	}
 	perf_event_update_userpage(event);