Skip to contentSkip to conversation

tools lib fs debugfs: Check if debugfs is mounted when handling ENOENT

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Jan 28, 2015

lore
Share & tools
lore

tip-bot for Arnaldo Carvalho de Melo

author merge bot
#0 lore raw
Commit-ID:  f816b3cc99804a9f771315331deb36abec47f5b4
Gitweb:     http://git.kernel.org/tip/f816b3cc99804a9f771315331deb36abec47f5b4
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 22 Jan 2015 16:35:42 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 22 Jan 2015 17:02:23 -0300

tools lib fs debugfs: Check if debugfs is mounted when handling ENOENT

If debugfs was already mounted, then its a matter of not finding the tracepoint, tell the user that perhaps a CONFIG_ setting is not enabled.

Cc Adrian Hunter <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc David Ahern <[email protected]>
Cc Don Zickus <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Stephane Eranian <[email protected]>
Link http://lkml.kernel.org/n/[email protected] open here
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/lib/api/fs/debugfs.c | 7 +++++++
 1 file changed, 7 insertions(+)
tools/lib/api/fs/debugfs.c +7 -0
index bf9e216..d2b18e8 100644
@@ -106,6 +106,13 @@ int debugfs__strerror_open(int err, char *buf, size_t size, const char *filename
 
 	switch (err) {
 	case ENOENT:
+		if (debugfs_found) {
+			snprintf(buf, size,
+				 "Error:\tFile %s/%s not found.\n"
+				 "Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n",
+				 debugfs_mountpoint, filename);
+			break;
+		}
 		snprintf(buf, size, "%s",
 			 "Error:\tUnable to find debugfs\n"
 			 "Hint:\tWas your kernel compiled with debugfs support?\n"