perf top: Fix crash when annotating symbol
tip-bot for Jiri Olsa
merge botCommit-ID: a7eec4c677fe60c8760fa9054b578c743ff6a3ec Gitweb: https://git.kernel.org/tip/a7eec4c677fe60c8760fa9054b578c743ff6a3ec Author: Jiri Olsa <[email protected]> AuthorDate: Wed, 15 Nov 2017 11:53:21 +0100 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Fri, 17 Nov 2017 12:16:24 -0300
perf top: Fix crash when annotating symbol
Ravi reported crash in perf top --stdio when annotating a function [1]. The issue was, that we don't pass evsel pointer into symbol__annotate() function, which got over looked in the last annotation changes.
[1] https://marc.info/?l=linux-kernel&m=151060884412702&w=2
Committer note:
This fixes the crash, but makes it stumble into another bug, double locking the annotation data structures, that is in turn fixed by the next patch in this series.
Signed-off-by Jiri Olsa <[email protected]>
Tested-by Ravi Bangoria <[email protected]>
Cc Adrian Hunter <[email protected]>
Cc Andi Kleen <[email protected]>
Cc David Ahern <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Wang Nan <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/builtin-top.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/builtin-top.c +2 -1
@@ -99,6 +99,7 @@ static void perf_top__resize(struct perf_top *top)static int perf_top__parse_source (struct perf_top *top,struct hist_entry *he) { +struct perf_evsel *evsel =hists_to_evsel (he->hists);struct symbol *sym;struct annotation *notes;struct map *map;
@@ -137,7 +138,7 @@ static int perf_top__parse_source(struct perf_top *top, struct hist_entry *he)return err; } - err =symbol__annotate (sym, map,NULL ,0 ,NULL ,NULL ); + err =symbol__annotate (sym, map, evsel,0 ,NULL ,NULL );if (err ==0 ) { out_assign: top->sym_filter_entry = he;