tools lib traceevent: No need to check for < 0 on an unsigned enum
Commit-ID: e46466b8bd5918626250dc0d6cb6c2147a611087 Gitweb: http://git.kernel.org/tip/e46466b8bd5918626250dc0d6cb6c2147a611087 Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Fri, 9 Nov 2012 15:42:26 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Fri, 9 Nov 2012 17:35:15 -0300
tools lib traceevent: No need to check for < 0 on an unsigned enum
gcc on f14 32-bit complains:
tools/lib/traceevent/event-parse.c: In function ‘pevent_register_print_function’:
tools/lib/traceevent/event-parse.c:5366:3: error: comparison of unsigned expression < 0 is always false
This is because:
enum pevent_func_arg_type type;
this enum doesn't have any negative value, so gcc makes it an 'unsigned int'. Fix it by removing the < 0 test.
Cc David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
Cc Steven Rostedt <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/lib/traceevent/event-parse.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
tools/lib/traceevent/event-parse.c +1 -1
@@ -5363,7 +5363,7 @@ int pevent_register_print_function(struct pevent *pevent,if (type ==PEVENT_FUNC_ARG_VOID )break ; -if (type <0 || type >=PEVENT_FUNC_ARG_MAX_TYPES ) { +if (type >=PEVENT_FUNC_ARG_MAX_TYPES ) {do_warning ("Invalid argument type %d" , type); ret =PEVENT_ERRNO__INVALID_ARG_TYPE ; goto out_free;