perf evlist: Factor out asprintf routine to build a tracepoint pid filter
A message that is not in the archive (sent off-list or not yet received): [email protected]
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 05cea4492c9dd28439cc73de1047ab3b26033736 Gitweb: https://git.kernel.org/tip/05cea4492c9dd28439cc73de1047ab3b26033736 Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Mon, 07 Oct 2019 16:43:03 -03:00 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitterDate: Wed, 09 Oct 2019 11:23:52 -03:00
perf evlist: Factor out asprintf routine to build a tracepoint pid filter
Will be used to append such lists to existing filters.
Cc Adrian Hunter <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Luis Cláudio Gonçalves <[email protected]>
Cc Namhyung Kim <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/util/evlist.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-)
tools/perf/util/evlist.c +15 -4
@@ -1053,6 +1053,9 @@ int perf_evlist__set_tp_filter(struct evlist *evlist, const char *filter)struct evsel *evsel;int err =0 ; +if (filter ==NULL ) +return -1 ; +evlist__for_each_entry (evlist, evsel) {if (evsel->core.attr.type !=PERF_TYPE_TRACEPOINT )continue ;
@@ -1065,16 +1068,15 @@ int perf_evlist__set_tp_filter(struct evlist *evlist, const char *filter)return err; } -int perf_evlist__set_tp_filter_pids (struct evlist *evlist,size_t npids,pid_t *pids) +static char *asprintf__tp_filter_pids (size_t npids,pid_t *pids) {char *filter; -int ret =-1 ;size_t i;for (i =0 ; i < npids; ++i) {if (i ==0 ) {if (asprintf (&filter,"common_pid != %d" , pids[i]) <0 ) -return -1 ; +return NULL ; }else {char *tmp;
@@ -1086,9 +1088,18 @@ int perf_evlist__set_tp_filter_pids(struct evlist *evlist, size_t npids, pid_t * } } - ret =perf_evlist__set_tp_filter (evlist, filter); +return filter; out_free:free (filter); +return NULL ; +} + +int perf_evlist__set_tp_filter_pids (struct evlist *evlist,size_t npids,pid_t *pids) +{ +char *filter =asprintf__tp_filter_pids (npids, pids); +int ret =perf_evlist__set_tp_filter (evlist, filter); + +free (filter);return ret; }