perf stat: Adjust stall cycles warning percentages

tip:perf/stat tip-bot for Ingo Molnar 1 participant 1 message Apr 29, 2011 perf events

Share & tools

tip-bot for Ingo Molnar

author

2011-04-29 12:47 UTC #0 lore raw

Commit-ID:  2b427e14b77dbf3e05f1bd0785f1d07ea5fe924e
Gitweb:     http://git.kernel.org/tip/2b427e14b77dbf3e05f1bd0785f1d07ea5fe924e
Author:     Ingo Molnar <[email protected]>
AuthorDate: Fri, 29 Apr 2011 14:16:18 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 29 Apr 2011 14:35:57 +0200

perf stat: Adjust stall cycles warning percentages

Adjust to color thresholds to better match the percentages seen in real workloads. Both are now a bit more sensitive.

Cc Peter Zijlstra <[email protected]>

Cc Arnaldo Carvalho de Melo <[email protected]>

Cc Frederic Weisbecker <[email protected]>

Link http://lkml.kernel.org/n/[email protected] open here

Signed-off-by Ingo Molnar <[email protected]>

---
 tools/perf/builtin-stat.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

tools/perf/builtin-stat.c +4 -4

index e454499..2492a0e 100644
@@ -492,11 +492,11 @@ static void print_stalled_cycles_frontend(int cpu, struct perf_evsel *evsel __us
 		ratio = avg / total * 100.0;
 
 	color = PERF_COLOR_NORMAL;
-	if (ratio > 75.0)
+	if (ratio > 50.0)
 		color = PERF_COLOR_RED;
-	else if (ratio > 50.0)
+	else if (ratio > 30.0)
 		color = PERF_COLOR_MAGENTA;
-	else if (ratio > 20.0)
+	else if (ratio > 10.0)
 		color = PERF_COLOR_YELLOW;
 
 	fprintf(stderr, " #   ");

@@ -519,7 +519,7 @@ static void print_stalled_cycles_backend(int cpu, struct perf_evsel *evsel __use
 		color = PERF_COLOR_RED;
 	else if (ratio > 50.0)
 		color = PERF_COLOR_MAGENTA;
-	else if (ratio > 25.0)
+	else if (ratio > 20.0)
 		color = PERF_COLOR_YELLOW;
 
 	fprintf(stderr, " #   ");