Skip to contentSkip to conversation

sched: Turn on SD_BALANCE_NEWIDLE

tip:sched/balancing tip-bot for Ingo Molnar 1 participant 1 message Sep 4, 2009 x86

lore
Share & tools
lore
#0 lore raw
Commit-ID:  840a0653100dbde599ae8ddf83fa214dfa5fd1aa
Gitweb:     http://git.kernel.org/tip/840a0653100dbde599ae8ddf83fa214dfa5fd1aa
Author:     Ingo Molnar <[email protected]>
AuthorDate: Fri, 4 Sep 2009 11:32:54 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 4 Sep 2009 11:52:54 +0200

sched: Turn on SD_BALANCE_NEWIDLE

Start the re-tuning of the balancer by turning on newidle.

It improves hackbench performance and parallelism on a 4x4 box. The "perf stat --repeat 10" measurements give us:

domain0 domain1
.......................................
-SD_BALANCE_NEWIDLE -SD_BALANCE_NEWIDLE:
2041.273208 task-clock-msecs # 9.354 CPUs ( +- 0.363% )

+SD_BALANCE_NEWIDLE -SD_BALANCE_NEWIDLE:
2086.326925 task-clock-msecs # 11.934 CPUs ( +- 0.301% )

+SD_BALANCE_NEWIDLE +SD_BALANCE_NEWIDLE:
2115.289791 task-clock-msecs # 12.158 CPUs ( +- 0.263% )

Cc Andreas Herrmann <[email protected]>
Cc Andreas Herrmann <[email protected]>
Cc Gautham R Shenoy <[email protected]>
Cc Balbir Singh <[email protected]>

LKML-Reference: <new-submission>

---
 arch/x86/include/asm/topology.h |    2 +-
 include/linux/topology.h        |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/x86/include/asm/topology.h +1 -1
index be29eb8..ef7bc7f 100644
@@ -142,7 +142,7 @@ extern unsigned long node_remap_size[];
 	.forkexec_idx		= SD_FORKEXEC_IDX,			\
 									\
 	.flags			= 1*SD_LOAD_BALANCE			\
-				| 0*SD_BALANCE_NEWIDLE			\
+				| 1*SD_BALANCE_NEWIDLE			\
 				| 1*SD_BALANCE_EXEC			\
 				| 1*SD_BALANCE_FORK			\
 				| 0*SD_WAKE_IDLE			\
include/linux/topology.h +2 -2
index fe2c032..66774fd 100644
@@ -126,7 +126,7 @@ int arch_update_cpu_topology(void);
 	.forkexec_idx		= 1,					\
 									\
 	.flags			= 1*SD_LOAD_BALANCE			\
-				| 0*SD_BALANCE_NEWIDLE			\
+				| 1*SD_BALANCE_NEWIDLE			\
 				| 1*SD_BALANCE_EXEC			\
 				| 1*SD_BALANCE_FORK			\
 				| 0*SD_WAKE_IDLE			\
@@ -160,7 +160,7 @@ int arch_update_cpu_topology(void);
 	.forkexec_idx		= 1,					\
 									\
 	.flags			= 1*SD_LOAD_BALANCE			\
-				| 0*SD_BALANCE_NEWIDLE			\
+				| 1*SD_BALANCE_NEWIDLE			\
 				| 1*SD_BALANCE_EXEC			\
 				| 1*SD_BALANCE_FORK			\
 				| 0*SD_WAKE_IDLE			\