Skip to contentSkip to conversation

perf test: Clarify the "sample parsing" test entry

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Oct 25, 2013 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  11a4d435a2d75918039540f08b259969c63b8635
Gitweb:     http://git.kernel.org/tip/11a4d435a2d75918039540f08b259969c63b8635
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Tue, 22 Oct 2013 15:24:58 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 23 Oct 2013 09:55:37 -0300

perf test: Clarify the "sample parsing" test entry

Before:

[root@sandy ~]# perf test -v 22
22: Test sample parsing :
--- start ---
sample format has changed - test needs updating ---- end ----
Test sample parsing: FAILED! [root@sandy ~]#

After:

[root@sandy ~]# perf test -v 22
22: Test sample parsing :
--- start ---
sample format has changed, some new PERF_SAMPLE_ bit was introduced - test needs updating ---- end ----
Test sample parsing: FAILED!
[root@sandy ~]#

Cc Adrian Hunter <[email protected]>
Cc Andi Kleen <[email protected]>
Cc David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
---
 tools/perf/tests/sample-parsing.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/sample-parsing.c +1 -1
index 77f598d..17d000c 100644
@@ -276,7 +276,7 @@ int test__sample_parsing(void)
 	 * were added.
 	 */
 	if (PERF_SAMPLE_MAX > PERF_SAMPLE_IDENTIFIER << 1) {
-		pr_debug("sample format has changed - test needs updating\n");
+		pr_debug("sample format has changed, some new PERF_SAMPLE_ bit was introduced - test needs updating\n");
 		return -1;
 	}