perf hists browser gtk: Use hist_entry__has_callchains()

tip:perf/urgent tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Jun 14, 2018 perf events

Share & tools

tip-bot for Arnaldo Carvalho de Melo

author merge bot

2018-06-14 06:20 UTC #0 lore raw

Commit-ID:  29f9fcdd3f8edccad5809cf939ce921752460fe7
Gitweb:     https://git.kernel.org/tip/29f9fcdd3f8edccad5809cf939ce921752460fe7
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 7 Jun 2018 14:33:31 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 7 Jun 2018 14:33:31 -0300

perf hists browser gtk: Use hist_entry__has_callchains()

Since we can't go from struct hists to struct evsel for all cases (c2c is an exception) and we have access to the hist_entry, use hist_entry__has_callchains() in the GTK+ hists browser to figure out if callchains are available.

Cc Adrian Hunter <[email protected]>

Cc David Ahern <[email protected]>

Cc Jin Yao <[email protected]>

Cc Jiri Olsa <[email protected]>

Cc Namhyung Kim <[email protected]>

Cc Wang Nan <[email protected]>

Link https://lkml.kernel.org/n/[email protected] open here

Signed-off-by Arnaldo Carvalho de Melo <[email protected]>

---
 tools/perf/ui/gtk/hists.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

tools/perf/ui/gtk/hists.c +1 -1

index b085f1b3e34d..4ab663ec3e5e 100644
@@ -382,7 +382,7 @@ static void perf_gtk__show_hists(GtkWidget *window, struct hists *hists,
 			gtk_tree_store_set(store, &iter, col_idx++, s, -1);
 		}
 
-		if (hists__has_callchains(hists) &&
+		if (hist_entry__has_callchains(h) &&
 		    symbol_conf.use_callchain && hists__has(hists, sym)) {
 			if (callchain_param.mode == CHAIN_GRAPH_REL)
 				total = symbol_conf.cumulate_callchain ?