perf core: Generalize max_stack sysctl handler
Subsystems (2)
tip-bot for Arnaldo Carvalho de Melo
merge botCommit-ID: a831100aeefbe6d9f3e47a3e2712f82c042f1f5c Gitweb: http://git.kernel.org/tip/a831100aeefbe6d9f3e47a3e2712f82c042f1f5c Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Tue, 10 May 2016 16:34:53 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 16 May 2016 23:11:49 -0300
perf core: Generalize max_stack sysctl handler
So that it can be used for other stack related knobs, such as the upcoming one to tweak the max number of of contexts per stack sample.
In all those cases we can only change the value if there are no perf sessions collecting stacks, so they need to grab that mutex, etc.
Cc David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- kernel/events/callchain.c | 5 +++-- kernel/sysctl.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-)
kernel/events/callchain.c +3 -2
@@ -228,7 +228,8 @@ exit_put:int perf_event_max_stack_handler (struct ctl_table *table,int write,void __user *buffer,size_t *lenp,loff_t *ppos) { -int new_value = sysctl_perf_event_max_stack, ret; +int *value = table->data; +int new_value = *value, ret;struct ctl_table new_table = *table; new_table.data = &new_value;
@@ -240,7 +241,7 @@ int perf_event_max_stack_handler(struct ctl_table *table, int write,if (atomic_read (&nr_callchain_events)) ret = -EBUSY ;else - sysctl_perf_event_max_stack = new_value; + *value = new_value;mutex_unlock (&callchain_mutex);
kernel/sysctl.c +1 -1
@@ -1149,7 +1149,7 @@ static struct ctl_table kern_table[] = { }, { .procname = "perf_event_max_stack", - .data = NULL, /* filled in by handler */ + .data = &sysctl_perf_event_max_stack, .maxlen = sizeof(sysctl_perf_event_max_stack), .mode = 0644, .proc_handler = perf_event_max_stack_handler,