Skip to contentSkip to conversation

sched: Add WF_FORK

tip:sched/core tip-bot for Peter Zijlstra 1 participant 1 message Sep 16, 2009 Scheduler

lore
Share & tools
lore
#0 lore raw
Commit-ID:  a7558e01056f5191ff2ecff53b075dcb9e484188
Gitweb:     http://git.kernel.org/tip/a7558e01056f5191ff2ecff53b075dcb9e484188
Author:     Peter Zijlstra <[email protected]>
AuthorDate: Mon, 14 Sep 2009 20:02:34 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 15 Sep 2009 16:51:31 +0200

sched: Add WF_FORK

Avoid the cache buddies from biasing the time distribution away from fork()ers. Normally the next buddy will be the preferred scheduling target, but this makes fork()s prefer to run the new child, whereas we prefer to run the parent, since that will generate more work.

LKML-Reference: <new-submission>

---
 include/linux/sched.h |    1 +
 kernel/sched.c        |    2 +-
 kernel/sched_fair.c   |    2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)
include/linux/sched.h +1 -0
index 3b07168..ee1f889 100644
@@ -1028,6 +1028,7 @@ struct sched_domain;
  * wake flags
  */
 #define WF_SYNC		0x01		/* waker goes to sleep after wakup */
+#define WF_FORK		0x02		/* child wakeup after fork */
 
 struct sched_class {
 	const struct sched_class *next;
kernel/sched.c +1 -1
index 4da335c..0d4c4fe 100644
@@ -2602,7 +2602,7 @@ void wake_up_new_task(struct task_struct *p, unsigned long clone_flags)
 		inc_nr_running(rq);
 	}
 	trace_sched_wakeup_new(rq, p, 1);
-	check_preempt_curr(rq, p, 0);
+	check_preempt_curr(rq, p, WF_FORK);
 #ifdef CONFIG_SMP
 	if (p->sched_class->task_wake_up)
 		p->sched_class->task_wake_up(rq, p);
kernel/sched_fair.c +1 -1
index 007958e..6766959 100644
@@ -1580,7 +1580,7 @@ static void check_preempt_wakeup(struct rq *rq, struct task_struct *p, int flags
 	 */
 	if (sched_feat(LAST_BUDDY) && likely(se->on_rq && curr != rq->idle))
 		set_last_buddy(se);
-	if (sched_feat(NEXT_BUDDY))
+	if (sched_feat(NEXT_BUDDY) && !(flags & WF_FORK))
 		set_next_buddy(pse);
 
 	/*