Skip to contentSkip to conversation

perf tools: Emit clearer message for sys_perf_event_open ENOENT return

tip:perf/urgent tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Jan 11, 2011 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  aa7bc7ef73efc46d7c3a0e185eefaf85744aec98
Gitweb:     http://git.kernel.org/tip/aa7bc7ef73efc46d7c3a0e185eefaf85744aec98
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Mon, 10 Jan 2011 13:36:24 -0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 10 Jan 2011 13:36:24 -0200

perf tools: Emit clearer message for sys_perf_event_open ENOENT return

Improve sys_perf_event_open ENOENT return handling in top and record, just like 5a3446b does for stat.

Cc: David Ahern <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Stephane Eranian <[email protected]>
Cc: Tom Zanussi <[email protected]>
LKML-Reference: <new-submission>

---
 tools/perf/builtin-record.c |    3 +++
 tools/perf/builtin-top.c    |    2 ++
 2 files changed, 5 insertions(+), 0 deletions(-)
tools/perf/builtin-record.c +3 -0
index 7bc0490..7069bd3 100644
@@ -331,6 +331,9 @@ try_again:
 			else if (err ==  ENODEV && cpu_list) {
 				die("No such device - did you specify"
 					" an out-of-range profile CPU?\n");
+			} else if (err == ENOENT) {
+				die("%s event is not supported. ",
+				     event_name(evsel));
 			} else if (err == EINVAL && sample_id_all_avail) {
 				/*
 				 * Old kernel, no attr->sample_id_type_all field
tools/perf/builtin-top.c +2 -0
index 1e67ab9..6ce4042 100644
@@ -1247,6 +1247,8 @@ try_again:
 				die("Permission error - are you root?\n"
 					"\t Consider tweaking"
 					" /proc/sys/kernel/perf_event_paranoid.\n");
+			if (err == ENOENT)
+				die("%s event is not supported. ", event_name(evsel));
 			/*
 			 * If it's cycles then fall back to hrtimer
 			 * based cpu-clock-tick sw counter, which