Skip to contentSkip to conversation

perf_counter tools: Standardize color printing

tip:perfcounters/core tip-bot for Ingo Molnar 1 participant 1 message Jun 8, 2009 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  aefcf37b82886260d8540c9fb815e613c8977e06
Gitweb:     http://git.kernel.org/tip/aefcf37b82886260d8540c9fb815e613c8977e06
Author:     Ingo Molnar <[email protected]>
AuthorDate: Mon, 8 Jun 2009 23:15:28 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 8 Jun 2009 23:15:28 +0200

perf_counter tools: Standardize color printing

The rule is:

- high overhead: red
- mid overhead: green
- low overhead: normal (white/black)

Cc: Peter Zijlstra <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
LKML-Reference: <new-submission>

---
 tools/perf/builtin-annotate.c |    5 +++--
 tools/perf/builtin-report.c   |   13 ++++++++-----
 tools/perf/builtin-top.c      |   13 ++++++++-----
 3 files changed, 19 insertions(+), 12 deletions(-)
tools/perf/builtin-annotate.c +3 -2
index 0e23fe9..3334a8b 100644
@@ -1085,8 +1085,9 @@ parse_line(FILE *file, struct symbol *sym, uint64_t start, uint64_t len)
 			percent = 100.0 * hits / sym->hist_sum;
 
 		/*
-		 * We color high-overhead entries in red, low-overhead
-		 * entries in green - and keep the middle ground normal:
+		 * We color high-overhead entries in red, mid-overhead
+		 * entries in green - and keep the low overhead places
+		 * normal:
 		 */
 		if (percent >= 5.0)
 			color = PERF_COLOR_RED;
tools/perf/builtin-report.c +8 -5
index 61d8718..0b18cb9 100644
@@ -693,13 +693,16 @@ hist_entry__fprintf(FILE *fp, struct hist_entry *self, uint64_t total_samples)
 		char *color = PERF_COLOR_NORMAL;
 
 		/*
-		 * We color high-overhead entries in red, low-overhead
-		 * entries in green - and keep the middle ground normal:
+		 * We color high-overhead entries in red, mid-overhead
+		 * entries in green - and keep the low overhead places
+		 * normal:
 		 */
-		if (percent >= 5.0)
+		if (percent >= 5.0) {
 			color = PERF_COLOR_RED;
-		if (percent < 0.5)
-			color = PERF_COLOR_GREEN;
+		} else {
+			if (percent >= 0.5)
+				color = PERF_COLOR_GREEN;
+		}
 
 		ret = color_fprintf(fp, color, "   %6.2f%%",
 				(self->count * 100.0) / total_samples);
tools/perf/builtin-top.c +8 -5
index be1698f..8ba2480 100644
@@ -248,13 +248,16 @@ static void print_sym_table(void)
 					 sum_ksamples));
 
 		/*
-		 * We color high-overhead entries in red, low-overhead
-		 * entries in green - and keep the middle ground normal:
+		 * We color high-overhead entries in red, mid-overhead
+		 * entries in green - and keep the low overhead places
+		 * normal:
 		 */
-		if (pcnt >= 5.0)
+		if (pcnt >= 5.0) {
 			color = PERF_COLOR_RED;
-		if (pcnt < 0.5)
-			color = PERF_COLOR_GREEN;
+		} else {
+			if (pcnt >= 0.5)
+				color = PERF_COLOR_GREEN;
+		}
 
 		if (nr_counters == 1)
 			printf("%20.2f - ", syme->weight);