tools lib traceevent plugin function: Initialize 'index' variable
tip-bot for Arnaldo Carvalho de Melo
merge botCommit-ID: e8c6f437fd12d39e462962eaed2315bac597d34c Gitweb: http://git.kernel.org/tip/e8c6f437fd12d39e462962eaed2315bac597d34c Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Mon, 13 Feb 2017 13:33:57 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 13 Feb 2017 17:22:33 -0300
tools lib traceevent plugin function: Initialize 'index' variable
Detected with clang:
CC /tmp/build/perf/plugin_function.o
plugin_function.c:145:6: warning: variable 'index' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (parent && ftrace_indent->set)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
plugin_function.c:148:29: note: uninitialized use occurs here
trace_seq_printf(s, "%*s", index*3, "");
^~~~~
plugin_function.c:145:2: note: remove the 'if' if its condition is always true
if (parent && ftrace_indent->set)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
plugin_function.c:145:6: warning: variable 'index' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]
if (parent && ftrace_indent->set)
^~~~~~
plugin_function.c:148:29: note: uninitialized use occurs here
trace_seq_printf(s, "%*s", index*3, "");
^~~~~
plugin_function.c:145:6: note: remove the '&&' if its condition is always true
if (parent && ftrace_indent->set)
^~~~~~~~~
plugin_function.c:133:11: note: initialize the variable 'index' to silence this warning
int index;
^
= 02 warnings generated.
Reviewed-by Steven Rostedt (VMware) <[email protected]>
Cc Adrian Hunter <[email protected]>
Cc David Ahern <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Wang Nan <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/lib/traceevent/plugin_function.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/lib/traceevent/plugin_function.c +1 -1
@@ -130,7 +130,7 @@ static int function_handler(struct trace_seq *s, struct pevent_record *record,unsigned long long pfunction;const char *func;const char *parent; -int index; +int index =0 ;if (pevent_get_field_val (s, event,"ip" , record, &function,1 ))return trace_seq_putc (s,'!' );