Skip to contentSkip to conversation

perf, x86: Add INSTRUCTION_DECODER config flag

tip:perf/pebs tip-bot for Ingo Molnar 1 participant 1 message Mar 10, 2010 x86

lore
Share & tools
lore
#0 lore raw
Commit-ID:  ba7e4d13fc7e25af1d167d40e6f028298dfc55ad
Gitweb:     http://git.kernel.org/tip/ba7e4d13fc7e25af1d167d40e6f028298dfc55ad
Author:     Ingo Molnar <[email protected]>
AuthorDate: Sat, 6 Jun 2009 13:58:12 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 10 Mar 2010 13:34:12 +0100

perf, x86: Add INSTRUCTION_DECODER config flag

The PEBS+LBR decoding magic needs the insn_get_length() infrastructure to be able to decode x86 instruction length.

So split it out of KPROBES dependency and make it enabled when either KPROBES or PERF_EVENTS is enabled.

Cc: Peter Zijlstra <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
LKML-Reference: <new-submission>

---
 arch/x86/Kconfig      |    3 +++
 arch/x86/lib/Makefile |    2 +-
 2 files changed, 4 insertions(+), 1 deletions(-)
arch/x86/Kconfig +3 -0
index e984403..e1240f6 100644
@@ -58,6 +58,9 @@ config X86
 	select HAVE_ARCH_KMEMCHECK
 	select HAVE_USER_RETURN_NOTIFIER
 
+config INSTRUCTION_DECODER
+	def_bool (KPROBES || PERF_EVENTS)
+
 config OUTPUT_FORMAT
 	string
 	default "elf32-i386" if X86_32
arch/x86/lib/Makefile +1 -1
index 419386c..cbaf8f2 100644
@@ -20,7 +20,7 @@ lib-y := delay.o
 lib-y += thunk_$(BITS).o
 lib-y += usercopy_$(BITS).o getuser.o putuser.o
 lib-y += memcpy_$(BITS).o
-lib-$(CONFIG_KPROBES) += insn.o inat.o
+lib-$(CONFIG_INSTRUCTION_DECODER) += insn.o inat.o
 
 obj-y += msr.o msr-reg.o msr-reg-export.o