Skip to contentSkip to conversation

perf record: Explicity program a default counter

tip:perfcounters/core tip-bot for Peter Zijlstra 1 participant 1 message Jun 12, 2009 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  bbd36e5e6aa6f1757c84cdb406b6eb81686d14af
Gitweb:     http://git.kernel.org/tip/bbd36e5e6aa6f1757c84cdb406b6eb81686d14af
Author:     Peter Zijlstra <[email protected]>
AuthorDate: Thu, 11 Jun 2009 23:11:50 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 12 Jun 2009 14:28:52 +0200

perf record: Explicity program a default counter

Up until now record has worked on the assumption that type=0, config=0 was a suitable configuration - which it is. Lets make this a little more explicit and more readable via the use of proper symbols.

[ Impact: cleanup ]

Cc Mike Galbraith <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>

LKML-Reference: <new-submission>

---
 tools/perf/builtin-record.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
tools/perf/builtin-record.c +5 -2
index 29259e7..0f5771f 100644
@@ -568,8 +568,11 @@ int cmd_record(int argc, const char **argv, const char *prefix)
 	if (!argc && target_pid == -1 && !system_wide)
 		usage_with_options(record_usage, options);
 
-	if (!nr_counters)
-		nr_counters = 1;
+	if (!nr_counters) {
+		nr_counters	= 1;
+		attrs[0].type	= PERF_TYPE_HARDWARE;
+		attrs[0].config = PERF_COUNT_HW_CPU_CYCLES;
+	}
 
 	for (counter = 0; counter < nr_counters; counter++) {
 		if (attrs[counter].sample_period)