Skip to contentSkip to conversation

avr32/at32ap: Fix race in installing chained IRQ handler

tip:irq/urgent Hans-Christian Egtvedt 1 participant 1 message Jun 28, 2015 1 message not in the archive

lore
Share & tools
lore

Hans-Christian Egtvedt

author Acked-by
#1 lore raw
In reply to a message not in the archive
Quoted 2 lines · tip-bot for Thomas Gleixner

avr32/at32ap: Fix race in installing chained IRQ handler

<snipp>

Quoted 14 lines
Cc Julia Lawall <[email protected]>
Cc Haavard Skinnemoen <[email protected]>
Cc Hans-Christian Egtvedt <[email protected]>
---
 arch/avr32/mach-at32ap/extint.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/avr32/mach-at32ap/extint.c +0 -0
index cfb298d..2d48b6a 100644

arch/avr32/mach-at32ap/extint.c static int __init eic_probe(struct platform_device *pdev) · line 237

Quoted 9 lines
arch/avr32/mach-at32ap/extint.c +1 -2
@@ -231,8 +231,7 @@ static int __init eic_probe(struct platform_device *pdev)
 		irq_set_chip_data(eic->first_irq + i, eic);
 	}
 
-	irq_set_chained_handler(int_irq, demux_eic_irq);
-	irq_set_handler_data(int_irq, eic);
+	irq_set_chained_handler_and_data(int_irq, demux_eic_irq, eic);
 
 	if (pdev->id == 0) {
 		nmi_eic = eic;

Good fix, wil you pass it through your git tree, or would you prefer I add it to the AVR32 tree? I have nothing in the pipe, hence feel free to add it to a series if you are preparing fixes.

Signature · 2 lines
mvh
Hans-Christian Egtvedt