perf report/top: Make ENTER consistently bring up menu
A message that is not in the archive (sent off-list or not yet received): [email protected]
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 9218a9132f83d2c08cd23c1fd8e8e9b63b47cb5f Gitweb: https://git.kernel.org/tip/9218a9132f83d2c08cd23c1fd8e8e9b63b47cb5f Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Thu, 12 Dec 2019 10:02:33 -03:00 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitterDate: Mon, 06 Jan 2020 11:46:10 -03:00
perf report/top: Make ENTER consistently bring up menu
When callchains are present the ENTER key switches from bringing up the menu that offers Annotation, Zoom by DSO, etc to expanding/collapsing one callchain level, causing confusion, fix it by making it consistently bring up the menu and use '+' to expand/collapse one callchain level.
Next patch will also add an entry to the menu to allow expanding/collapsing, so that people used to ENTER expanding one callchain level can quickly find it and use it instead.
Reported-by Linus Torvalds <[email protected]>
Reviewed-by Jiri Olsa <[email protected]>
Cc Adrian Hunter <[email protected]>
Cc Andi Kleen <[email protected]>
Cc Jin Yao <[email protected]>
Cc Kan Liang <[email protected]>
Cc Namhyung Kim <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/ui/browsers/hists.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/ui/browsers/hists.c +2 -1
@@ -706,7 +706,7 @@ int hist_browser__run(struct hist_browser *browser, const char *help, browser->show_headers = !browser->show_headers;hist_browser__update_rows (browser);break ; -case K_ENTER : +case '+' :if (hist_browser__toggle_fold (browser))break ;/* fall thru */
@@ -2858,6 +2858,7 @@ static int perf_evsel__hists_browse(struct evsel *evsel, int nr_events,"For symbolic views (--sort has sym):\n\n" \"ENTER Zoom into DSO/Threads & Annotate current symbol\n" \"ESC Zoom out\n" \ +"+ Expand/Collapse one callchain level\n" \"a Annotate current symbol\n" \"C Collapse all callchains\n" \"d Zoom into current DSO\n" \