perf tools: Synthesize anon MMAP records again
tip-bot for Don Zickus
merge botCommit-ID: 9d4ecc8893832337daf241236841db966fa53489 Gitweb: http://git.kernel.org/tip/9d4ecc8893832337daf241236841db966fa53489 Author: Don Zickus <[email protected]> AuthorDate: Wed, 13 Nov 2013 15:32:06 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Thu, 14 Nov 2013 16:00:01 -0300
perf tools: Synthesize anon MMAP records again
When introducing the PERF_RECORD_MMAP2 in:
5c5e854bc760 perf tools: Add attr->mmap2 support
A check for the number of entries parsed by sscanf was introduced that assumed all of the 8 fields needed to be correctly parsed so that particular /proc/pid/maps line would be considered synthesizable.
That broke anon records synthesizing, as it doesn't have the 'execname' field.
Fix it by keeping the sscanf return check, changing it to not require that the 'execname' variable be parsed, so that the preexisting logic can kick in and set it to '//anon'.
This should get things like JIT profiling working again.
Signed-off-by Don Zickus <[email protected]>
Cc Bill Gray <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Joe Mario <[email protected]>
Cc Richard Fowles <[email protected]>
Cc Stephane Eranian <[email protected]>
[ commit log message is mine, dzickus reported the problem with a patch ]
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/util/event.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
tools/perf/util/event.c +4 -2
@@ -209,8 +209,10 @@ static int perf_event__synthesize_mmap_events(struct perf_tool *tool, &event->mmap.start, &event->mmap.len, prot, &event->mmap.pgoff, execname); - -if (n !=5 ) +/* +* Anon maps don't have the execname. +*/ +if (n <4 )continue ;/* * Just like the kernel, see __perf_event_mmap in kernel/perf_event.c