Skip to contentSkip to conversation

tracing: Prevent unloadable modules from using trace_bprintk()

tip:perf/urgent Linus Torvalds 3 participants 3 messages Oct 26, 2010 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 2 lines · tip-bot for Steven Rostedt

tracing: Prevent unloadable modules from using trace_bprintk()

I still don't think this patch makes sense.

Some of it is just totally insane. The CONFIG_MODVERSIONS check is just crazy. MODVERSIONS has nothing what-so-ever to do with the issue.

Don't do this. It's total voodoo programming.

Linus

#2 lore raw
Quoted 11 lines · Linus Torvalds
Quoted 2 lines · tip-bot for Steven Rostedt

tracing: Prevent unloadable modules from using trace_bprintk()

I still don't think this patch makes sense.

Some of it is just totally insane. The CONFIG_MODVERSIONS check is just crazy. MODVERSIONS has nothing what-so-ever to do with the issue.

Don't do this. It's total voodoo programming.

Yeah, I think Ingo pulled this by mistake (I asked him to do some pull requests, and this was probably mixed in the real ones). I purposely pulled it out of my other pull requests so we could debate it more.

The right answer is what Li Zefan said and that is to simply flush the ring buffer on module removal if the module uses a trace_bprintk(). We already do this for tracepoints.

-- Steve

#3 lore raw
In reply to Linus Torvalds
Quoted 6 lines · Linus Torvalds
Quoted 2 lines · tip-bot for Steven Rostedt

tracing: Prevent unloadable modules from using trace_bprintk()

I still don't think this patch makes sense.

Yeah, i said that to Steve too in the discussion and essentially NAK-ed that patch - it's just that i pulled the wrong branch. After seeing the commit mail i realized my mistake and unpulled this one and pulled the right one ...

Thanks,

Ingo