Skip to contentSkip to conversation

perf stat: Fix zero total printouts

tip:perf/urgent tip-bot for Ingo Molnar 1 participant 1 message Sep 22, 2009 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  c7f7fea30b7e52c9d4b9cef271110a98d59adcbc
Gitweb:     http://git.kernel.org/tip/c7f7fea30b7e52c9d4b9cef271110a98d59adcbc
Author:     Ingo Molnar <[email protected]>
AuthorDate: Tue, 22 Sep 2009 14:53:51 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 22 Sep 2009 15:01:47 +0200

perf stat: Fix zero total printouts

Before:

0 sched:sched_switch # nan M/sec

After:

0 sched:sched_switch # 0.000 M/sec

Cc: Peter Zijlstra <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
LKML-Reference: <new-submission>

---
 tools/perf/builtin-stat.c |   18 ++++++++++++++----
 1 files changed, 14 insertions(+), 4 deletions(-)
tools/perf/builtin-stat.c +14 -4
index 16af2d8..e5f6ece 100644
@@ -338,14 +338,24 @@ static void nsec_printout(int counter, double avg)
 
 static void abs_printout(int counter, double avg)
 {
+	double total, ratio = 0.0;
+
 	fprintf(stderr, " %14.0f  %-24s", avg, event_name(counter));
 
 	if (MATCH_EVENT(HARDWARE, HW_INSTRUCTIONS, counter)) {
-		fprintf(stderr, " # %10.3f IPC  ",
-				avg / avg_stats(&runtime_cycles_stats));
+		total = avg_stats(&runtime_cycles_stats);
+
+		if (total)
+			ratio = avg / total;
+
+		fprintf(stderr, " # %10.3f IPC  ", ratio);
 	} else {
-		fprintf(stderr, " # %10.3f M/sec",
-				1000.0 * avg / avg_stats(&runtime_nsecs_stats));
+		total = avg_stats(&runtime_nsecs_stats);
+
+		if (total)
+			ratio = 1000.0 * avg / total;
+
+		fprintf(stderr, " # %10.3f M/sec", ratio);
 	}
 }