perf hists: Factor out duplicated code
Commit-ID: cc5edb0eb9ce892b530e34a5d110382483587942 Gitweb: http://git.kernel.org/tip/cc5edb0eb9ce892b530e34a5d110382483587942 Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Fri, 16 Jul 2010 12:35:07 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Sat, 17 Jul 2010 15:45:55 -0300
perf hists: Factor out duplicated code
Introducing hists__remove_entry_filter.
Cc: Frederic Weisbecker <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Stephane Eranian <[email protected]>
LKML-Reference: <new-submission>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/util/hist.c | 36 ++++++++++++++++++------------------ 1 files changed, 18 insertions(+), 18 deletions(-)
tools/perf/util/hist.c +18 -18
@@ -795,6 +795,21 @@ enum hist_filter { HIST_FILTER__THREAD, }; +static void hists__remove_entry_filter (struct hists *self,struct hist_entry *h, +enum hist_filter filter) +{ + h->filtered &= ~(1 << filter); +if (h->filtered) +return ; + + ++self->nr_entries; + self->stats.total_period += h->period; + self->stats.nr_events[PERF_RECORD_SAMPLE ] += h->nr_events; + +if (h->ms.sym && self->max_sym_namelen < h->ms.sym->namelen) + self->max_sym_namelen = h->ms.sym->namelen; +} +void hists__filter_by_dso (struct hists *self,const struct dso *dso) {struct rb_node *nd;
@@ -814,15 +829,7 @@ void hists__filter_by_dso(struct hists *self, const struct dso *dso)continue ; } - h->filtered &= ~(1 <<HIST_FILTER__DSO ); -if (!h->filtered) { - ++self->nr_entries; - self->stats.total_period += h->period; - self->stats.nr_events[PERF_RECORD_SAMPLE ] += h->nr_events; -if (h->ms.sym && - self->max_sym_namelen < h->ms.sym->namelen) - self->max_sym_namelen = h->ms.sym->namelen; - } +hists__remove_entry_filter (self, h,HIST_FILTER__DSO ); } }
@@ -841,15 +848,8 @@ void hists__filter_by_thread(struct hists *self, const struct thread *thread) h->filtered |= (1 <<HIST_FILTER__THREAD );continue ; } - h->filtered &= ~(1 <<HIST_FILTER__THREAD ); -if (!h->filtered) { - ++self->nr_entries; - self->stats.total_period += h->period; - self->stats.nr_events[PERF_RECORD_SAMPLE ] += h->nr_events; -if (h->ms.sym && - self->max_sym_namelen < h->ms.sym->namelen) - self->max_sym_namelen = h->ms.sym->namelen; - } + +hists__remove_entry_filter (self, h,HIST_FILTER__THREAD ); } }