Skip to contentSkip to conversation

perf hists: Fix period symbol_conf.field_sep display

tip:perf/core tip-bot for Jiri Olsa 1 participant 1 message Jan 24, 2013 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  c0d246b85fc7d42688d7a5d999ea671777caf65b
Gitweb:     http://git.kernel.org/tip/c0d246b85fc7d42688d7a5d999ea671777caf65b
Author:     Jiri Olsa <[email protected]>
AuthorDate: Sat, 20 Oct 2012 22:14:10 +0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Sun, 9 Dec 2012 08:46:05 -0300

perf hists: Fix period symbol_conf.field_sep display

Currently we don't properly display hist data with symbol_conf.field_sep separator. We need to display either space or separator.

Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Corey Ashford <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Namhyung Kim <[email protected]>
---
 tools/perf/ui/hist.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
tools/perf/ui/hist.c +5 -1
index 0a5281f..6e639b5 100644
@@ -472,11 +472,15 @@ int hist_entry__period_snprintf(struct perf_hpp *hpp, struct hist_entry *he,
 		return 0;
 
 	perf_hpp__for_each_format(fmt) {
+		/*
+		 * If there's no field_sep, we still need
+		 * to display initial '  '.
+		 */
 		if (!sep || !first) {
 			ret = scnprintf(hpp->buf, hpp->size, "%s", sep ?: "  ");
 			advance_hpp(hpp, ret);
+		} else
 			first = false;
-		}
 
 		if (color && fmt->color)
 			ret = fmt->color(hpp, he);