Skip to contentSkip to conversation

perf evsel: Introduce perf_evsel__prev() method

tip:perf/urgent tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Nov 15, 2013 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  d87fcb4a2d990ba2de9284ede84a816c5066d54b
Gitweb:     http://git.kernel.org/tip/d87fcb4a2d990ba2de9284ede84a816c5066d54b
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Wed, 13 Nov 2013 15:56:40 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Thu, 14 Nov 2013 16:00:16 -0300

perf evsel: Introduce perf_evsel__prev() method

Just one use so far, on the hists browser, for completeness since there we use perf_evlist__{first,last} and perf_evsel__next() for handling the TAB and UNTAB keys.

Cc Adrian Hunter <[email protected]>
Cc David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
---
 tools/perf/ui/browsers/hists.c | 2 +-
 tools/perf/util/evsel.h        | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)
tools/perf/ui/browsers/hists.c +1 -1
index 089fd37..a440e03 100644
@@ -1855,7 +1855,7 @@ browse_hists:
 				if (pos->node.prev == &evlist->entries)
 					pos = perf_evlist__last(evlist);
 				else
-					pos = list_entry(pos->node.prev, struct perf_evsel, node);
+					pos = perf_evsel__prev(pos);
 				goto browse_hists;
 			case K_ESC:
 				if (!ui_browser__dialog_yesno(&menu->b,
tools/perf/util/evsel.h +5 -0
index f502965..1ea7c92 100644
@@ -279,6 +279,11 @@ static inline struct perf_evsel *perf_evsel__next(struct perf_evsel *evsel)
 	return list_entry(evsel->node.next, struct perf_evsel, node);
 }
 
+static inline struct perf_evsel *perf_evsel__prev(struct perf_evsel *evsel)
+{
+	return list_entry(evsel->node.prev, struct perf_evsel, node);
+}
+
 /**
  * perf_evsel__is_group_leader - Return whether given evsel is a leader event
  *