genirq: Add IRQCHIP_SET_TYPE_MASKED flag
A message that is not in the archive (sent off-list or not yet received): [email protected]
Review int __irq_set_trigger(struct irq_desc *desc, unsigned
Quoted 1 line
(quoted diff) +0
-0@@ -588,11 +596,13 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned
int irq,
Review int __irq_set_trigger(struct irq_desc *desc, unsigned · line 598
Quoted 5 lines
(quoted diff) +1
-1if (chip != desc->irq_data.chip) irq_chip_set_defaults(desc->irq_data.chip); - return 0; + ret = 0;
I've just tested the patch and noticed that a 'break' is missing here.
Quoted 18 lines
(quoted diff) +3
-1default: pr_err("setting trigger mode %lu for irq %u failed (%pF)\n", flags, irq, chip->irq_set_type); } + if (unmask) + unmask_irq(desc); return ret; }@@ -669,7 +679,7 @@ again: #ifdef CONFIG_SMP /* - * Check whether we need to change the affinity of the interrupt thread. + * Check whether we need to chasnge the affinity of the interrupt thread. */ static void irq_thread_check_affinity(struct irq_desc *desc, struct irqaction *action)
Quoted 9 lines · Lars-Peter Clausen
Review int __irq_set_trigger(struct irq_desc *desc, unsigned
Quoted 1 line
(quoted diff) +0
-0@@ -588,11 +596,13 @@ int __irq_set_trigger(struct irq_desc *desc, unsignedint irq,
Review int __irq_set_trigger(struct irq_desc *desc, unsigned · line 598
Quoted 5 lines
(quoted diff) +1
-1if (chip != desc->irq_data.chip) irq_chip_set_defaults(desc->irq_data.chip); - return 0; + ret = 0;I've just tested the patch and noticed that a 'break' is missing here.
Grmbl. Thanks for catching that !
Thanks,
tglx