Skip to contentSkip to conversation

perf ui: No need to set ui_browser to 1 twice

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Aug 15, 2019 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  1cd8fa288eb83c1fe0dfa492b09d228a8d802fbf
Gitweb:     https://git.kernel.org/tip/1cd8fa288eb83c1fe0dfa492b09d228a8d802fbf
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Tue, 13 Aug 2019 12:07:14 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 14 Aug 2019 11:00:00 -0300

perf ui: No need to set ui_browser to 1 twice

We need to do it only when fallbacking from GTK to the TUI.

---
 tools/perf/ui/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/ui/setup.c +1 -1
index 44fe824e96cd..3bc7c9a6fae9 100644
@@ -89,9 +89,9 @@ void setup_browser(bool fallback_to_pager)
 		printf("GTK browser requested but could not find %s\n",
 		       PERF_GTK_DSO);
 		sleep(1);
+		use_browser = 1;
 		/* fall through */
 	case 1:
-		use_browser = 1;
 		if (ui__init() == 0)
 			break;
 		/* fall through */