Skip to contentSkip to conversation

x86: perf_counter cleanup

tip:perfcounters/core Peter Zijlstra 3 participants 3 messages Mar 8, 2009 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 10 lines · Jaswinder Singh Rajput
Commit-ID:  e255357764f92afcafafbd4879b222b8c752065a
Gitweb:     http://git.kernel.org/tip/e255357764f92afcafafbd4879b222b8c752065a
Author:     "Jaswinder Singh Rajput" <[email protected]>
AuthorDate: Sun, 8 Mar 2009 17:09:49 +0530
Commit:     Ingo Molnar <[email protected]>
CommitDate: Sun, 8 Mar 2009 16:26:50 +0100

x86: perf_counter cleanup

Remove unused variables and duplicate header file.

Why did you commit this?

Until someone from AMD steps up and either tells us they're going to be 48bits _ALWAYS_ or that it's impossible to detect dynamically, I'd rather try and get the dynamic thing working.

Quoted 34 lines
---
 arch/x86/kernel/cpu/perf_counter.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
arch/x86/kernel/cpu/perf_counter.c +0 -5
index 1df4210..155bc3c 100644
@@ -17,7 +17,6 @@
 #include <linux/kdebug.h>
 #include <linux/sched.h>
 
-#include <asm/perf_counter.h>
 #include <asm/apic.h>
 
 static bool perf_counters_initialized __read_mostly;
@@ -954,9 +953,6 @@ static struct pmc_x86_ops *pmc_intel_init(void)
 
 static struct pmc_x86_ops *pmc_amd_init(void)
 {
-	u64 old;
-	int bits;
-
 	nr_counters_generic = 4;
 	nr_counters_fixed = 0;
 	counter_value_mask = 0x0000FFFFFFFFFFFFULL;
--

To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
In reply to H. Peter Anvin
Quoted 20 lines · H. Peter Anvin
Quoted 10 lines · Peter Zijlstra
Quoted 9 lines · Jaswinder Singh Rajput
Commit-ID:  e255357764f92afcafafbd4879b222b8c752065a
Gitweb:     http://git.kernel.org/tip/e255357764f92afcafafbd4879b222b8c752065a
Author:     "Jaswinder Singh Rajput" <[email protected]>
AuthorDate: Sun, 8 Mar 2009 17:09:49 +0530
Commit:     Ingo Molnar <[email protected]>
CommitDate: Sun, 8 Mar 2009 16:26:50 +0100

x86: perf_counter cleanup

Quoted 8 lines
Quoted 1 line

Remove unused variables and duplicate header file.

Why did you commit this?

Until someone from AMD steps up and either tells us they're going to be 48bits _ALWAYS_ or that it's impossible to detect dynamically, I'd rather try and get the dynamic thing working.

Quoted 4 lines

That would be good, but there really is absolutely no reason to leave in variables which are unused in the current code and therefore give a gcc warning. It's not like adding new declaration is hard.

yeah. Adding a TODO there might be worth doing though.

Ingo

#2 lore raw
In reply to Peter Zijlstra
Quoted 10 lines · Peter Zijlstra
Quoted 9 lines · Jaswinder Singh Rajput
Commit-ID:  e255357764f92afcafafbd4879b222b8c752065a
Gitweb:     http://git.kernel.org/tip/e255357764f92afcafafbd4879b222b8c752065a
Author:     "Jaswinder Singh Rajput" <[email protected]>
AuthorDate: Sun, 8 Mar 2009 17:09:49 +0530
Commit:     Ingo Molnar <[email protected]>
CommitDate: Sun, 8 Mar 2009 16:26:50 +0100

x86: perf_counter cleanup

Quoted 8 lines
Quoted 1 line

Remove unused variables and duplicate header file.

Why did you commit this?

Until someone from AMD steps up and either tells us they're going to be 48bits _ALWAYS_ or that it's impossible to detect dynamically, I'd rather try and get the dynamic thing working.

That would be good, but there really is absolutely no reason to leave in variables which are unused in the current code and therefore give a gcc warning. It's not like adding new declaration is hard.

-hpa

Signature · 2 lines
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.