sched: Turn on SD_WAKE_IDLE for 'close' domains
Commit-ID: e54c7073fae0683b90b3157e97142202c7334b79 Gitweb: http://git.kernel.org/tip/e54c7073fae0683b90b3157e97142202c7334b79 Author: Ingo Molnar <[email protected]> AuthorDate: Fri, 4 Sep 2009 11:38:07 +0200 Committer: Ingo Molnar <[email protected]> CommitDate: Fri, 4 Sep 2009 12:17:06 +0200
sched: Turn on SD_WAKE_IDLE for 'close' domains
Turn it on for the thread, core and cpu domain defaults.
Same argument as for NEWIDLE: we want to err on the side of over-balancing, and mute the effect of that when it hurts a workload.
On a NUMA box (4x4) i get better CPU utilization:
Performance counter stats for './hackbench 10' (10 runs):
Before: 2124.478000 task-clock-msecs # 12.196 CPUs ( +- 0.614% ) After: 2232.558805 task-clock-msecs # 12.601 CPUs ( +- 0.852% )
It's probably not worth turning it on for the NUMA domain though, as even on this fast-NUMA box it's break-even in terms of cost versus improvement:
After #2: 2288.062034 task-clock-msecs # 12.909 CPUs ( +- 0.864% )
Acked-by Peter Zijlstra <[email protected]>
Cc Andreas Herrmann <[email protected]>
Cc Andreas Herrmann <[email protected]>
Cc Gautham R Shenoy <[email protected]>
Cc Balbir Singh <[email protected]>
LKML-Reference: <new-submission>
Signed-off-by Ingo Molnar <[email protected]>
--- include/linux/topology.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
include/linux/topology.h +3 -3
@@ -95,7 +95,7 @@ int arch_update_cpu_topology(void); | 1*SD_BALANCE_NEWIDLE \ |1 *SD_BALANCE_EXEC \ |1 *SD_BALANCE_FORK \ - |0 *SD_WAKE_IDLE \ + |1 *SD_WAKE_IDLE \ |1 *SD_WAKE_AFFINE \ |1 *SD_WAKE_BALANCE \ |1 *SD_SHARE_CPUPOWER \
@@ -129,7 +129,7 @@ int arch_update_cpu_topology(void); | 1*SD_BALANCE_NEWIDLE \ |1 *SD_BALANCE_EXEC \ |1 *SD_BALANCE_FORK \ - |0 *SD_WAKE_IDLE \ + |1 *SD_WAKE_IDLE \ |1 *SD_WAKE_AFFINE \ |1 *SD_WAKE_BALANCE \ |0 *SD_SHARE_CPUPOWER \
@@ -163,7 +163,7 @@ int arch_update_cpu_topology(void); | 1*SD_BALANCE_NEWIDLE \ |1 *SD_BALANCE_EXEC \ |1 *SD_BALANCE_FORK \ - |0 *SD_WAKE_IDLE \ + |1 *SD_WAKE_IDLE \ |0 *SD_WAKE_AFFINE \ |1 *SD_WAKE_BALANCE \ |0 *SD_SHARE_CPUPOWER \