Skip to contentSkip to conversation

perf report: Add front-entry cache for lookups

tip:perfcounters/core tip-bot for Ingo Molnar 1 participant 1 message Jun 3, 2009 Documentation

lore
Share & tools
lore
#0 lore raw
Commit-ID:  eed4dcd443da7a46131ef37c7a389b444905960e
Gitweb:     http://git.kernel.org/tip/eed4dcd443da7a46131ef37c7a389b444905960e
Author:     Ingo Molnar <[email protected]>
AuthorDate: Wed, 3 Jun 2009 19:59:24 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 3 Jun 2009 20:03:32 +0200

perf report: Add front-entry cache for lookups

Before:

Performance counter stats for './perf report -i perf.data.big':

     12453988058  instructions

Performance counter stats for './perf report -i perf.data.big':

     12379566017  instructions

0.60% reduction.

Cc: Peter Zijlstra <[email protected]>
Cc: Mike Galbraith <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Corey Ashford <[email protected]>
Cc: Marcelo Tosatti <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Cc: Thomas Gleixner <[email protected]>
LKML-Reference: <new-submission>

---
 Documentation/perf_counter/builtin-report.c |   15 ++++++++++++++-
 1 files changed, 14 insertions(+), 1 deletions(-)
Documentation/perf_counter/builtin-report.c +14 -1
index e837bb9..33b3b15 100644
@@ -229,6 +229,7 @@ static int thread__set_comm(struct thread *self, const char *comm)
 }
 
 static struct rb_root threads;
+static struct thread *last_match;
 
 static struct thread *threads__findnew(pid_t pid)
 {
@@ -236,12 +237,22 @@ static struct thread *threads__findnew(pid_t pid)
 	struct rb_node *parent = NULL;
 	struct thread *th;
 
+	/*
+	 * Font-end cache - PID lookups come in blocks,
+	 * so most of the time we dont have to look up
+	 * the full rbtree:
+	 */
+	if (last_match && last_match->pid == pid)
+		return last_match;
+
 	while (*p != NULL) {
 		parent = *p;
 		th = rb_entry(parent, struct thread, rb_node);
 
-		if (th->pid == pid)
+		if (th->pid == pid) {
+			last_match = th;
 			return th;
+		}
 
 		if (pid < th->pid)
 			p = &(*p)->rb_left;
@@ -253,7 +264,9 @@ static struct thread *threads__findnew(pid_t pid)
 	if (th != NULL) {
 		rb_link_node(&th->rb_node, parent, p);
 		rb_insert_color(&th->rb_node, &threads);
+		last_match = th;
 	}
+
 	return th;
 }