perf tools: Kill die()
tip-bot for Arnaldo Carvalho de Melo
merge botCommit-ID: fef2a735167a827a65bbdf1791abe0dd070ce372 Gitweb: http://git.kernel.org/tip/fef2a735167a827a65bbdf1791abe0dd070ce372 Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Tue, 27 Jun 2017 11:49:13 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Tue, 27 Jun 2017 11:49:13 -0300
perf tools: Kill die()
Finally can nuke this function, no more users.
Cc Adrian Hunter <[email protected]>
Cc David Ahern <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Wang Nan <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/tests/attr.c | 10 +++++----- tools/perf/util/usage.c | 22 ---------------------- 2 files changed, 5 insertions(+), 27 deletions(-)
tools/perf/tests/attr.c +5 -5
@@ -18,6 +18,7 @@* permissions. All the event text files are stored there. */ +#include <debug.h> #include <errno.h> #include <inttypes.h> #include <stdlib.h>
@@ -29,14 +30,11 @@#include <sys/stat.h> #include <unistd.h> #include "../perf.h" -#include "util.h" #include <subcmd/exec-cmd.h> #include "tests.h" #define ENV "PERF_TEST_ATTR" -extern int verbose; -static char *dir;void test_attr__init (void )
@@ -138,8 +136,10 @@ void test_attr__open(struct perf_event_attr *attr, pid_t pid, int cpu, {int errno_saved = errno; -if (store_event (attr, pid, cpu, fd, group_fd, flags)) -die ("test attr FAILED" ); +if (store_event (attr, pid, cpu, fd, group_fd, flags)) { +pr_err ("test attr FAILED" ); +exit (128 ); + } errno = errno_saved; }
tools/perf/util/usage.c +0 -22
@@ -9,25 +9,12 @@#include "util.h" #include "debug.h" -static void report (const char *prefix,const char *err,va_list params) -{ -char msg[1024 ]; -vsnprintf (msg,sizeof (msg), err, params); -fprintf (stderr," %s%s\n" , prefix, msg); -} -static __noreturn void usage_builtin (const char *err) {fprintf (stderr,"\n Usage: %s\n" , err);exit (129 ); } -static __noreturn void die_builtin (const char *err,va_list params) -{ -report (" Fatal: " , err, params); -exit (128 ); -} -/* If we are in a dlopen()ed .so write to a global variable would segfault * (ugh), so keep things static. */ static void (*usage_routine)(const char *err)__noreturn = usage_builtin;
@@ -36,12 +23,3 @@ void usage(const char *err) {usage_routine (err); } - -void die (const char *err, ...) -{ -va_list params; - -va_start (params, err); -die_builtin (err, params); -va_end (params); -}