perf tools: Remove stale prototypes from builtin.h

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Apr 24, 2017 perf events

Share & tools

tip-bot for Arnaldo Carvalho de Melo

author merge bot

2017-04-24 21:15 UTC #0 lore raw

Commit-ID:  a3b70b3bb34296a63b43614f13991111eccbb44a
Gitweb:     http://git.kernel.org/tip/a3b70b3bb34296a63b43614f13991111eccbb44a
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Wed, 19 Apr 2017 20:46:41 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 24 Apr 2017 13:43:33 -0300

perf tools: Remove stale prototypes from builtin.h

Some, like prune_packed_objects() are clearly git specific, others don't have implementations and some are used in just one place, make them static.

Link http://lkml.kernel.org/n/[email protected] open here

Signed-off-by Arnaldo Carvalho de Melo <[email protected]>

---
 tools/perf/builtin.h | 4 ----
 tools/perf/perf.c    | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

tools/perf/builtin.h +0 -4

index 26669bf..d4d19fe 100644
@@ -2,16 +2,12 @@
 #define BUILTIN_H
 
 #include "util/util.h"
-#include "util/strbuf.h"
 
 extern const char perf_usage_string[];
 extern const char perf_more_info_string[];
 
 void list_common_cmds_help(void);
 const char *help_unknown_cmd(const char *cmd);
-void prune_packed_objects(int);
-int read_line_with_nul(char *buf, int size, FILE *file);
-int check_pager_config(const char *cmd);
 
 int cmd_annotate(int argc, const char **argv);
 int cmd_bench(int argc, const char **argv);

tools/perf/perf.c +1 -1

index 3565889..0b2cad0 100644
@@ -91,7 +91,7 @@ static int pager_command_config(const char *var, const char *value, void *data)
 }
 
 /* returns 0 for "no pager", 1 for "use pager", and -1 for "not specified" */
-int check_pager_config(const char *cmd)
+static int check_pager_config(const char *cmd)
 {
 	int err;
 	struct pager_config c;