Skip to contentSkip to conversation

perf ui browser: Free browser->helpline() on ui_browser__hide()

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Jan 31, 2013 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  56ab7140325c835c8bb53cf3bca0cf7b6e967f15
Gitweb:     http://git.kernel.org/tip/56ab7140325c835c8bb53cf3bca0cf7b6e967f15
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Thu, 24 Jan 2013 22:45:21 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Fri, 25 Jan 2013 12:49:29 -0300

perf ui browser: Free browser->helpline() on ui_browser__hide()

It is allocated at ui_browser__show(), so free it in its counterpart, ui_browser__hide().

Cc David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
---
 tools/perf/ui/browser.c | 2 ++
 1 file changed, 2 insertions(+)
tools/perf/ui/browser.c +2 -0
index 588bcb2..809ea46 100644
@@ -273,6 +273,8 @@ void ui_browser__hide(struct ui_browser *browser __maybe_unused)
 {
 	pthread_mutex_lock(&ui__lock);
 	ui_helpline__pop();
+	free(browser->helpline);
+	browser->helpline = NULL;
 	pthread_mutex_unlock(&ui__lock);
 }