perf tools: Remove redundant initialization of thread linkage members
tip-bot for Arnaldo Carvalho de Melo
merge botCommit-ID: fdce6a4edaada40136f0e61569b938c9a25f61d5 Gitweb: http://git.kernel.org/tip/fdce6a4edaada40136f0e61569b938c9a25f61d5 Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Fri, 22 May 2015 17:42:37 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Wed, 27 May 2015 12:21:44 -0300
perf tools: Remove redundant initialization of thread linkage members
A thread moves from a rb tree to a list, but can't be on both, because those linkage members are in a union. This is leftover from when I was debugging thread refcounting and had nuked that union.
It is harmless duplication, as RB_CLEAR_NODE() does again what INIT_LIST_HEAD does.
Cc Adrian Hunter <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc David Ahern <[email protected]>
Cc Don Zickus <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Stephane Eranian <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/util/thread.c | 2 -- 1 file changed, 2 deletions(-)
tools/perf/util/thread.c +0 -2
@@ -54,7 +54,6 @@ struct thread *thread__new(pid_t pid, pid_t tid)list_add (&comm->list, &thread->comm_list);atomic_set (&thread->refcnt,0 ); -INIT_LIST_HEAD (&thread->node);RB_CLEAR_NODE (&thread->rb_node); }
@@ -70,7 +69,6 @@ void thread__delete(struct thread *thread)struct comm *comm, *tmp;BUG_ON (!RB_EMPTY_NODE (&thread->rb_node)); -BUG_ON (!list_empty (&thread->node));thread_stack__free (thread);