Skip to contentSkip to conversation

perf tools: Use just forward declarations for struct thread where possible

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Apr 24, 2017

Subsystems (2)
perf events Performance events tooling arm64
lore
Share & tools
lore

tip-bot for Arnaldo Carvalho de Melo

author merge bot
#0 lore raw
Commit-ID:  e7ff8920e62f0188e77b1dc5dc5d9a7322c342d7
Gitweb:     http://git.kernel.org/tip/e7ff8920e62f0188e77b1dc5dc5d9a7322c342d7
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Wed, 19 Apr 2017 21:34:35 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 24 Apr 2017 13:43:35 -0300

perf tools: Use just forward declarations for struct thread where possible

Removing various instances of unnecessary includes, reducing the maze of header dependencies.

Link http://lkml.kernel.org/n/[email protected] open here
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/arch/arm/util/unwind-libdw.c | 1 +
 tools/perf/arch/x86/util/unwind-libdw.c | 1 +
 tools/perf/builtin-c2c.c                | 1 +
 tools/perf/builtin-inject.c             | 1 +
 tools/perf/builtin-mem.c                | 1 +
 tools/perf/builtin-timechart.c          | 1 +
 tools/perf/ui/browsers/hists.c          | 1 +
 tools/perf/ui/stdio/hist.c              | 1 +
 tools/perf/util/build-id.c              | 1 +
 tools/perf/util/hist.c                  | 1 +
 tools/perf/util/session.c               | 1 +
 tools/perf/util/session.h               | 3 +--
 tools/perf/util/sort.c                  | 1 +
 tools/perf/util/sort.h                  | 3 ++-
 tools/perf/util/unwind-libdw.h          | 6 ++++--
 15 files changed, 19 insertions(+), 5 deletions(-)
tools/perf/arch/arm/util/unwind-libdw.c +1 -0
index b4176c6..bacfa00 100644
@@ -1,6 +1,7 @@
 #include <elfutils/libdwfl.h>
 #include "../../util/unwind-libdw.h"
 #include "../../util/perf_regs.h"
+#include "../../util/event.h"
 
 bool libdw__arch_set_initial_registers(Dwfl_Thread *thread, void *arg)
 {
tools/perf/arch/x86/util/unwind-libdw.c +1 -0
index c4b7217..38dc9bb 100644
@@ -1,6 +1,7 @@
 #include <elfutils/libdwfl.h>
 #include "../../util/unwind-libdw.h"
 #include "../../util/perf_regs.h"
+#include "../../util/event.h"
 
 bool libdw__arch_set_initial_registers(Dwfl_Thread *thread, void *arg)
 {
tools/perf/builtin-c2c.c +1 -0
index a14be1c..e33b4ac 100644
@@ -32,6 +32,7 @@
 #include <asm/bug.h>
 #include "ui/browsers/hists.h"
 #include "evlist.h"
+#include "thread.h"
 
 struct c2c_hists {
 	struct hists		hists;
tools/perf/builtin-inject.c +1 -0
index 8bd791c..ea8db38 100644
@@ -18,6 +18,7 @@
 #include "util/data.h"
 #include "util/auxtrace.h"
 #include "util/jit.h"
+#include "util/thread.h"
 
 #include <subcmd/parse-options.h>
tools/perf/builtin-mem.c +1 -0
index 2e5be1d..e001c02 100644
@@ -12,6 +12,7 @@
 #include "util/data.h"
 #include "util/mem-events.h"
 #include "util/debug.h"
+#include "util/symbol.h"
 
 #define MEM_OPERATION_LOAD	0x1
 #define MEM_OPERATION_STORE	0x2
tools/perf/builtin-timechart.c +1 -0
index 38e2c43..4e2e616 100644
@@ -29,6 +29,7 @@
 #include <linux/rbtree.h>
 #include <linux/time64.h>
 #include "util/symbol.h"
+#include "util/thread.h"
 #include "util/callchain.h"
 
 #include "perf.h"
tools/perf/ui/browsers/hists.c +1 -0
index 1b12a69..69f4570 100644
@@ -14,6 +14,7 @@
 #include "../../util/sort.h"
 #include "../../util/util.h"
 #include "../../util/top.h"
+#include "../../util/thread.h"
 #include "../../arch/common.h"
 
 #include "../browsers/hists.h"
tools/perf/ui/stdio/hist.c +1 -0
index 5565105..42e432b 100644
@@ -6,6 +6,7 @@
 #include "../../util/evsel.h"
 #include "../../util/srcline.h"
 #include "../../util/string2.h"
+#include "../../util/thread.h"
 #include "../../util/sane_ctype.h"
 
 static size_t callchain__fprintf_left_margin(FILE *fp, int left_margin)
tools/perf/util/build-id.c +1 -0
index 687b5ad..168cc49 100644
@@ -15,6 +15,7 @@
 #include "build-id.h"
 #include "event.h"
 #include "symbol.h"
+#include "thread.h"
 #include <linux/kernel.h>
 #include "debug.h"
 #include "session.h"
tools/perf/util/hist.c +1 -0
index 2944458..cf0186a 100644
@@ -9,6 +9,7 @@
 #include "evsel.h"
 #include "annotate.h"
 #include "srcline.h"
+#include "thread.h"
 #include "ui/progress.h"
 #include <errno.h>
 #include <math.h>
tools/perf/util/session.c +1 -0
index 19d993f..3041c6b 100644
@@ -19,6 +19,7 @@
 #include "perf_regs.h"
 #include "asm/bug.h"
 #include "auxtrace.h"
+#include "thread.h"
 #include "thread-stack.h"
 #include "stat.h"
tools/perf/util/session.h +1 -2
index 1ffae42..47b5e7d 100644
@@ -5,8 +5,6 @@
 #include "event.h"
 #include "header.h"
 #include "machine.h"
-#include "symbol.h"
-#include "thread.h"
 #include "data.h"
 #include "ordered-events.h"
 #include <linux/kernel.h>

@@ -14,6 +12,7 @@
 #include <linux/perf_event.h>
 
 struct ip_callchain;
+struct symbol;
 struct thread;
 
 struct auxtrace;
tools/perf/util/sort.c +1 -0
index fe4fd7b..5762ae4 100644
@@ -6,6 +6,7 @@
 #include "hist.h"
 #include "comm.h"
 #include "symbol.h"
+#include "thread.h"
 #include "evsel.h"
 #include "evlist.h"
 #include "strlist.h"
tools/perf/util/sort.h +2 -1
index 8bcec05..b7c7559 100644
@@ -21,7 +21,8 @@
 #include "parse-events.h"
 #include "hist.h"
 #include "srcline.h"
-#include "thread.h"
+
+struct thread;
 
 extern regex_t parent_regex;
 extern const char *sort_order;
tools/perf/util/unwind-libdw.h +4 -2
index 5832866..4a2b269 100644
@@ -2,10 +2,12 @@
 #define __PERF_UNWIND_LIBDW_H
 
 #include <elfutils/libdwfl.h>
-#include "event.h"
-#include "thread.h"
 #include "unwind.h"
 
+struct machine;
+struct perf_sample;
+struct thread;
+
 bool libdw__arch_set_initial_registers(Dwfl_Thread *thread, void *arg);
 
 struct unwind_info {