Skip to contentSkip to conversation

tools: Fix shadowed declaration in err.h

tip:perf/core tip-bot for Jiri Olsa 1 participant 1 message Oct 1, 2015

lore
Share & tools
lore

tip-bot for Jiri Olsa

author merge bot
#0 lore raw
Commit-ID:  45633a169571e81835ec53fe0c089dd20f3195f1
Gitweb:     http://git.kernel.org/tip/45633a169571e81835ec53fe0c089dd20f3195f1
Author:     Jiri Olsa <[email protected]>
AuthorDate: Tue, 29 Sep 2015 16:53:12 +0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 30 Sep 2015 18:34:22 -0300

tools: Fix shadowed declaration in err.h

The error variable breaks build on CentOS 6.7, due to collision with global error symbol:

CC util/evlist.o
cc1: warnings being treated as errors
In file included from util/evlist.c:28:
tools/include/linux/err.h: In function ‘ERR_PTR’:
tools/include/linux/err.h:34: error: declaration of ‘error’ shadows a global declaration util/util.h:135: error: shadowed declaration is here

Using 'error_' name instead to fix it.

[ Use 'error_' instead of 'err' to, visually, not diverge too much from include/linux/err.h ]
---
 tools/include/linux/err.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/include/linux/err.h +2 -2
index c9ada48..bdc3dd8 100644
@@ -31,9 +31,9 @@
 
 #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
 
-static inline void * __must_check ERR_PTR(long error)
+static inline void * __must_check ERR_PTR(long error_)
 {
-	return (void *) error;
+	return (void *) error_;
 }
 
 static inline long __must_check PTR_ERR(__force const void *ptr)