perf trace beauty renameat: No need to include linux/fs.h
tip-bot for Arnaldo Carvalho de Melo
merge botCommit-ID: b64f1cc6d02ce92f7752545c0bd82dc052013167 Gitweb: https://git.kernel.org/tip/b64f1cc6d02ce92f7752545c0bd82dc052013167 Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Wed, 27 Mar 2019 10:16:43 -0300 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 1 Apr 2019 14:49:24 -0300
perf trace beauty renameat: No need to include linux/fs.h
There is no use for what is in that file, as everything is built by the tools/perf/trace/beauty/rename_flags.sh script from the copied kernel headers, the end result being:
$ cat /tmp/build/perf/trace/beauty/generated/rename_flags_array.c
static const char *rename_flags[] = {
[0 + 1] = "NOREPLACE",
[1 + 1] = "EXCHANGE",
[2 + 1] = "WHITEOUT",
};
$I.e. no use of any defines from uapi/linux/fs.h
Cc Adrian Hunter <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/trace/beauty/renameat.c | 1 - 1 file changed, 1 deletion(-)
tools/perf/trace/beauty/renameat.c +0 -1
@@ -2,7 +2,6 @@// Copyright (C) 2018, Red Hat Inc, Arnaldo Carvalho de Melo <[email protected]> #include "trace/beauty/beauty.h" -#include <uapi/linux/fs.h> static size_t renameat2__scnprintf_flags (unsigned long flags,char *bf,size_t size,bool show_prefix) {