Skip to contentSkip to conversation

objtool: Initialize variable to silence old compiler

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Jul 16, 2016 objtool

lore
Share & tools
lore
#0 lore raw
Commit-ID:  b49364f36cfdb6d540ac961102d7ffaf84279bb6
Gitweb:     http://git.kernel.org/tip/b49364f36cfdb6d540ac961102d7ffaf84279bb6
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Fri, 15 Jul 2016 17:32:52 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Fri, 15 Jul 2016 17:32:52 -0300

objtool: Initialize variable to silence old compiler

gcc version 4.1.2 20080704 (Red Hat 4.1.2-55) barfs with:

CC /tmp/build/objtool/builtin-check.o
cc1: warnings being treated as errors
builtin-check.c: In function 'cmd_check':
builtin-check.c:667: warning: 'prev_rela' may be used uninitialized in this function
mv: cannot stat `/tmp/build/objtool/.builtin-check.o.tmp': No such file or directory make[1]: *** [/tmp/build/objtool/builtin-check.o] Error 1

Init it to NULL to silence it.

---
 tools/objtool/builtin-check.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/objtool/builtin-check.c +1 -1
index 92d84b2..4ed30f4 100644
@@ -664,7 +664,7 @@ static int add_func_switch_tables(struct objtool_file *file,
 				  struct symbol *func)
 {
 	struct instruction *insn, *prev_jump;
-	struct rela *text_rela, *rodata_rela, *prev_rela;
+	struct rela *text_rela, *rodata_rela, *prev_rela = NULL;
 	int ret;
 
 	prev_jump = NULL;