Skip to contentSkip to conversation

perf callchain: Remove needless event.h include

tip: perf/urgent tip-bot2 for Arnaldo Carvalho de Melo 1 participant 1 message Sep 20, 2019 1 message not in the archive perf events

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

tip-bot2 for Arnaldo Carvalho de Melo

author merge bot Applied
#1 lore raw

The following commit has been merged into the perf/urgent branch of tip:

Commit-ID:     9c9e754fb804828473c5131bb3e7df78bde396e6
Gitweb:        https://git.kernel.org/tip/9c9e754fb804828473c5131bb3e7df78bde396e6
Author:        Arnaldo Carvalho de Melo <[email protected]>
AuthorDate:    Tue, 10 Sep 2019 17:24:07 +01:00
Committer:     Arnaldo Carvalho de Melo <[email protected]>
CommitterDate: Fri, 20 Sep 2019 09:19:21 -03:00

perf callchain: Remove needless event.h include

All we need is a bunch of struct forward declarations and then add event.h to the only place that was getting it indirectly via callchain.h.

---
 tools/perf/arch/powerpc/util/skip-callchain-idx.c | 1 +
 tools/perf/util/callchain.h                       | 5 ++++-
 tools/perf/util/evsel_fprintf.c                   | 1 +
 3 files changed, 6 insertions(+), 1 deletion(-)
tools/perf/arch/powerpc/util/skip-callchain-idx.c +1 -0
index fc9c2f5..3018a05 100644
@@ -13,6 +13,7 @@
 #include "util/callchain.h"
 #include "util/debug.h"
 #include "util/dso.h"
+#include "util/event.h" // struct ip_callchain
 #include "util/map.h"
 #include "util/symbol.h"
 
tools/perf/util/callchain.h +4 -1
index b042cee..83398e5 100644
@@ -4,12 +4,15 @@
 
 #include <linux/list.h>
 #include <linux/rbtree.h>
-#include "event.h"
 #include "map_symbol.h"
 #include "branch.h"
 
+struct addr_location;
 struct evsel;
+struct ip_callchain;
 struct map;
+struct perf_sample;
+struct thread;
 
 #define HELP_PAD "\t\t\t\t"
 
tools/perf/util/evsel_fprintf.c +1 -0
index 496fec0..a8cbdf4 100644
@@ -4,6 +4,7 @@
 #include <stdbool.h>
 #include <traceevent/event-parse.h>
 #include "evsel.h"
+#include "util/event.h"
 #include "callchain.h"
 #include "map.h"
 #include "strlist.h"