perf sort: Remove needless headers from sort.h, provide fwd struct decls
The following commit has been merged into the perf/core branch of tip:
Commit-ID: 185bcb92c80eae2d85ec834ea76a144fd163e2af Gitweb: https://git.kernel.org/tip/185bcb92c80eae2d85ec834ea76a144fd163e2af Author: Arnaldo Carvalho de Melo <[email protected]> AuthorDate: Thu, 22 Aug 2019 17:11:39 -03:00 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitterDate: Mon, 26 Aug 2019 11:58:29 -03:00
perf sort: Remove needless headers from sort.h, provide fwd struct decls
Reducing the includes hell a bit more, speeding up the build and avoiding needless rebuilds when just one of those files gets updated.
Cc Adrian Hunter <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/ui/browsers/res_sample.c | 2 ++ tools/perf/ui/browsers/scripts.c | 2 ++ tools/perf/ui/stdio/hist.c | 1 + tools/perf/util/callchain.c | 1 + tools/perf/util/sort.h | 15 ++------------- 5 files changed, 8 insertions(+), 13 deletions(-)
tools/perf/ui/browsers/res_sample.c +2 -0
@@ -6,6 +6,8 @@#include "sort.h" #include "config.h" #include "time-utils.h" +#include "../util.h" +#include "../../util/util.h" #include <linux/time64.h> #include <linux/zalloc.h>
tools/perf/ui/browsers/scripts.c +2 -0
@@ -1,5 +1,7 @@// SPDX-License-Identifier: GPL-2.0 +#include "../../builtin.h" #include "../../util/sort.h" +#include "../../util/util.h" #include "../../util/hist.h" #include "../../util/debug.h" #include "../../util/symbol.h"
tools/perf/ui/stdio/hist.c +1 -0
@@ -3,6 +3,7 @@#include <linux/string.h> #include "../../util/callchain.h" +#include "../../util/debug.h" #include "../../util/hist.h" #include "../../util/map.h" #include "../../util/map_groups.h"
tools/perf/util/callchain.c +1 -0
@@ -20,6 +20,7 @@#include "asm/bug.h" +#include "debug.h" #include "hist.h" #include "sort.h" #include "machine.h"
tools/perf/util/sort.h +2 -13
@@ -1,29 +1,18 @@/* SPDX-License-Identifier: GPL-2.0 */ #ifndef __PERF_SORT_H#define __PERF_SORT_H -#include "../builtin.h" -#include <regex.h> - -#include "color.h" +#include <stdbool.h> #include <linux/list.h> -#include "cache.h" #include <linux/rbtree.h> #include "map_symbol.h" #include "symbol_conf.h" -#include "string.h" #include "callchain.h" #include "values.h" -#include "../perf.h" -#include "debug.h" -#include "header.h" - -#include <subcmd/parse-options.h> -#include "parse-events.h" #include "hist.h" -#include "srcline.h" +struct option ;struct thread ;extern regex_t parent_regex;