Skip to contentSkip to conversation

perf hists browser: Inform how to reset the symbol filter

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Oct 14, 2015 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  4aa8e454d347a1c96a2322683a6798de7e17da5f
Gitweb:     http://git.kernel.org/tip/4aa8e454d347a1c96a2322683a6798de7e17da5f
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Mon, 12 Oct 2015 14:02:29 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 12 Oct 2015 14:02:29 -0300

perf hists browser: Inform how to reset the symbol filter

When in the hists browser, i.e. in 'perf report' or in 'perf top', it is possible to press '/' and specify a substring to filter by symbol name.

Clarify how to remove a filter by making the prompt be:

Please enter the name of symbol you want to see. To remove the filter later, press / + ENTER

Cc Adrian Hunter <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Stephane Eranian <[email protected]>
Cc Wang Nan <[email protected]>
---
 tools/perf/ui/browsers/hists.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/perf/ui/browsers/hists.c +2 -1
index eea1627..7728349 100644
@@ -1889,7 +1889,8 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
 			continue;
 		case '/':
 			if (ui_browser__input_window("Symbol to show",
-					"Please enter the name of symbol you want to see",
+					"Please enter the name of symbol you want to see.\n"
+					"To remove the filter later, press / + ENTER.",
 					buf, "ENTER: OK, ESC: Cancel",
 					delay_secs * 2) == K_ENTER) {
 				hists->symbol_filter_str = *buf ? buf : NULL;