Skip to contentSkip to conversation

perf trace: No need to enable evsels for workload started from perf

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Feb 18, 2015 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  f7aa222ff397bd99153a039578864c1a36b8f391
Gitweb:     http://git.kernel.org/tip/f7aa222ff397bd99153a039578864c1a36b8f391
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Tue, 3 Feb 2015 13:25:39 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Sat, 7 Feb 2015 13:08:03 +0100

perf trace: No need to enable evsels for workload started from perf

As they will have perf_event_attr.enable_on_exec set, starting as soon as we exec() the workload.

Cc Adrian Hunter <[email protected]>
Cc Borislav Petkov <[email protected]>
Cc David Ahern <[email protected]>
Cc Don Zickus <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
---
 tools/perf/builtin-trace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/builtin-trace.c +2 -2
index 7e935f1..66300ae 100644
@@ -2109,10 +2109,10 @@ static int trace__run(struct trace *trace, int argc, const char **argv)
 	if (err < 0)
 		goto out_error_mmap;
 
-	perf_evlist__enable(evlist);
-
 	if (forks)
 		perf_evlist__start_workload(evlist);
+	else
+		perf_evlist__enable(evlist);
 
 	trace->multiple_threads = evlist->threads->map[0] == -1 || evlist->threads->nr > 1;
 again: