Skip to contentSkip to conversation

perf hists browser: Add back callchain folding symbol

tip:perf/urgent tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message Oct 20, 2012 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  88a21d2f07d2a4bec2e3e03dd50a39683b938b10
Gitweb:     http://git.kernel.org/tip/88a21d2f07d2a4bec2e3e03dd50a39683b938b10
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Wed, 17 Oct 2012 13:54:08 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 17 Oct 2012 13:54:08 -0300

perf hists browser: Add back callchain folding symbol

The commit 5395a04841fc ("perf hists: Separate overhead and baseline columns") makes the "Overhead" column no more the first one, this caused the test that checks if it is time to show if a histogram entry has callchains never hits.

Fix it by checking if the 'i' variable is equal to PERF_HPP__OVERHEAD instead of 0.

Cc David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
---
 tools/perf/ui/browsers/hists.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
tools/perf/ui/browsers/hists.c +1 -1
index fe4430a..ef2f93c 100644
@@ -647,7 +647,7 @@ static int hist_browser__show_entry(struct hist_browser *browser,
 
 				ui_browser__set_percent_color(&browser->b, percent, current_entry);
 
-				if (i == 0 && symbol_conf.use_callchain) {
+				if (i == PERF_HPP__OVERHEAD && symbol_conf.use_callchain) {
 					slsmg_printf("%c ", folded_sign);
 					width -= 2;
 				}